Skip to content

Commit

Permalink
Merge pull request #1469 from vmware-tanzu/fix_typo_for_go1.19
Browse files Browse the repository at this point in the history
Fix typo that prevented compiling with Go 1.19
  • Loading branch information
benjaminapetersen authored Apr 3, 2023
2 parents 6ae3c0a + a041295 commit 64263fd
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 29 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@

package tlsassertions

func GetTlsErrorPrefix() string {
func GetTLSErrorPrefix() string {
return ""
}
22 changes: 0 additions & 22 deletions internal/testutil/tlsassertions/assertions_test.go

This file was deleted.

6 changes: 3 additions & 3 deletions test/integration/supervisor_oidc_client_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2022 the Pinniped contributors. All Rights Reserved.
// Copyright 2022-2023 the Pinniped contributors. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0

package integration
Expand Down Expand Up @@ -34,7 +34,7 @@ func TestOIDCClientStaticValidation_Parallel(t *testing.T) {
groupFix := strings.NewReplacer(".supervisor.pinniped.dev", ".supervisor."+env.APIGroupSuffix)
errFix := strings.NewReplacer(makeErrFix(reallyOld)...)

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Minute)
t.Cleanup(cancel)

namespaceClient := adminClient.CoreV1().Namespaces()
Expand Down Expand Up @@ -516,7 +516,7 @@ func makeErrFix(reallyOld bool) []string {
func TestOIDCClientControllerValidations_Parallel(t *testing.T) {
env := testlib.IntegrationEnv(t)

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Minute)
t.Cleanup(cancel)

secrets := testlib.NewKubernetesClientset(t).CoreV1().Secrets(env.SupervisorNamespace)
Expand Down
6 changes: 3 additions & 3 deletions test/integration/supervisor_oidcclientsecret_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ func TestKubectlOIDCClientSecretRequest_Parallel(t *testing.T) {

t.Run(tt.name, func(t *testing.T) {
t.Parallel()
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), 13*time.Minute)
t.Cleanup(cancel)

supervisorClient := testlib.NewSupervisorClientset(t)
Expand Down Expand Up @@ -877,7 +877,7 @@ func TestCreateOIDCClientSecretRequest_Parallel(t *testing.T) {

t.Run(tt.name, func(t *testing.T) {
t.Parallel()
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), 13*time.Minute)
t.Cleanup(cancel)

kubeClient := testlib.NewKubernetesClientset(t)
Expand Down Expand Up @@ -1020,7 +1020,7 @@ func prependSecret(list []string, newItem string) []string {
func TestOIDCClientSecretRequestUnauthenticated_Parallel(t *testing.T) {
env := testlib.IntegrationEnv(t)

ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Minute)
t.Cleanup(cancel)

client := testlib.NewAnonymousSupervisorClientset(t)
Expand Down

0 comments on commit 64263fd

Please sign in to comment.