Skip to content

[Bugfix] Don't disable existing loggers #7664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

a-ys
Copy link
Contributor

@a-ys a-ys commented Aug 19, 2024

One-liner that stops existing loggers from being disabled. By default, logging.dictConfig disables existing named loggers.

This bug only occurs when Ray is not installed (e.g. for AWS Neuron). This is because Ray adds this field to their logging configuration here.

FIX #5803

Code Example

import logging

logger = logging.getLogger("logger")

print(f"logger disabled: {logger.disabled}")
# Output: logger disabled: False

import vllm

print(f"logger disabled: {logger.disabled}")
# Before PR, if Ray is not installed:
# Output: logger disabled: True
# After PR:
# Output: logger disabled: False

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@simon-mo simon-mo merged commit da11523 into vllm-project:main Aug 19, 2024
19 of 23 checks passed
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Misc]: vLLM logger disables other existing loggers by default
2 participants