-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
Closed
Labels
Description
Anything you want to discuss about vllm.
Issue
The current default behavior of the logger in vLLM is to disable all other existing loggers. This can prevent logs from being outputted from other code that is defined/imported before vLLM is imported.
Details
The default logging config defined here does not include disable_existing_loggers=False
. When using logging.dictConfig() to configure logging, this value is set to True by default for backwards compatibility. Unless this is the intended behavior, I believe this key should be added to the configuration dictionary.
Happy to add this small change if maintainers agree with this. Thank you!
Jester6136