Skip to content

[Misc]: vLLM logger disables other existing loggers by default #5803

@a-ys

Description

@a-ys

Anything you want to discuss about vllm.

Issue

The current default behavior of the logger in vLLM is to disable all other existing loggers. This can prevent logs from being outputted from other code that is defined/imported before vLLM is imported.

Details

The default logging config defined here does not include disable_existing_loggers=False. When using logging.dictConfig() to configure logging, this value is set to True by default for backwards compatibility. Unless this is the intended behavior, I believe this key should be added to the configuration dictionary.

Happy to add this small change if maintainers agree with this. Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions