[Bugfix][Harmless] Fix hardcoded float16 dtype for model_is_embedding #7566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #7561
On main you would see a concerning but harmless message about casting to float16 for models that are bfloat16:
This PR removes that by making the
ModelConfig
made inmodel_is_embedding
just usedtype="auto"
:This is just a cosmetic issue since this config isn't actually used for loading the model, just to check if the model is for embedding