[Core] Add shutdown() method to ExecutorBase
#4349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Called when the LLMEngine is garbage collected. The executor might not otherwise be garbage collected itself if it is referenced from other threads. Default is no-op but can be overwritten by subclasses. In preparation for introducing a `MultiprocessingGPUExecutor`.
rkooo567
approved these changes
Apr 25, 2024
zhuohan123
approved these changes
Apr 25, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 6, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Called when the LLMEngine is garbage collected. The executor might not otherwise be garbage collected itself if it is referenced from other threads.
Default is no-op but can be overwritten by subclasses.
In preparation for introducing a
MultiprocessingGPUExecutor.