Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Build] AMD CI pipeline with extended set of tests. #4267

Merged
merged 37 commits into from
May 2, 2024
Merged

[CI/Build] AMD CI pipeline with extended set of tests. #4267

merged 37 commits into from
May 2, 2024

Conversation

Alexei-V-Ivanov-AMD
Copy link
Contributor

Extending the set of tests that are running on the AMD hardware.

simon-mo
simon-mo requested changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't duplicate the script, instead, make it takes arguments which can be arbitrary shell command. This is similar to the other CI system works.

@Alexei-V-Ivanov-AMD
Copy link
Contributor Author

Please don't duplicate the script, instead, make it takes arguments which can be arbitrary shell command. This is similar to the other CI system works.

OK, will update the script to accept config parameters that define which tests are run.

simon-mo
simon-mo approved these changes May 1, 2024
View reviewed changes
.buildkite/test-template.j2 Outdated Show resolved Hide resolved
Alexei-V-Ivanov-AMD
Alexei-V-Ivanov-AMD commented May 1, 2024
View reviewed changes
Copy link
Contributor Author

@Alexei-V-Ivanov-AMD Alexei-V-Ivanov-AMD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@Alexei-V-Ivanov-AMD
Copy link
Contributor Author

All tests are OK, ready to merge.

@simon-mo simon-mo enabled auto-merge (squash) May 2, 2024 17:42
@simon-mo simon-mo disabled auto-merge May 2, 2024 19:29
@simon-mo simon-mo merged commit 9b5c9f9 into vllm-project:main May 2, 2024
57 of 58 checks passed
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request May 6, 2024
@Alexei-V-Ivanov-AMD @simon-mo @robertgshaw2-redhat
[CI/Build] AMD CI pipeline with extended set of tests. (vllm-project#…
2ff2756 
…4267)

Co-authored-by: simon-mo <simon.mo@hey.com>
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request May 7, 2024
@Alexei-V-Ivanov-AMD @simon-mo @joerunde
[CI/Build] AMD CI pipeline with extended set of tests. (vllm-project#…
299066f 
…4267)

Co-authored-by: simon-mo <simon.mo@hey.com>
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request May 7, 2024
@Alexei-V-Ivanov-AMD @simon-mo @dtrifiro
[CI/Build] AMD CI pipeline with extended set of tests. (vllm-project#…
43907f1 
…4267)

Co-authored-by: simon-mo <simon.mo@hey.com>
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexei-V-Ivanov-AMD @simon-mo