-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc]Add customized information for models #4132
Conversation
@zhuohan123 could I trouble you to review this PR, I am not sure whether this feature is useful. If not, I will close this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be pretty useful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you
@mgoin It seems that we also need a collaborator to review this PR, is that right? |
@simon-mo could I trouble you to take a look at this PR, please? |
@zhuohan123 @simon-mo Could you please take a look at this PR? If it's not useful, I'll close it. I'm hoping to get some feedback. |
I think this is a good direction in general. You should add comment to point to the doc https://pytorch.org/docs/stable/generated/torch.nn.Module.html#torch.nn.Module.extra_repr , this feature is not well-known. In addition, please merge main into this branch to pass the CI. |
When I debug the VLLM, the model's print output always bothers me because it lacks details, as shown below:
By leveraging extra_repr, we can add more details to the model, and can achieve the following print output: