-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Multi LoRA Load \ Delete Support #3496
Open
gauravkr2108
wants to merge
8
commits into
vllm-project:main
Choose a base branch
from
gauravkr2108:lora-create-delete
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5ad27a9
Add load and delete endpoint for LoRA
gauravkr2108 f914d2d
Add Delete response as OpenAI Spec
gauravkr2108 a8d72b7
Add service method for load and delete LoRA operation
gauravkr2108 a52f2f3
Merge branch 'main' into lora-create-delete
gauravkr2108 2cac644
Update API signature to mark it private
gauravkr2108 d8dfaaa
Update LoRA method signature
gauravkr2108 464f94e
Add missing space
gauravkr2108 b21fb56
Merge branch 'vllm-project:main' into lora-create-delete
gauravkr2108 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ | |
ChatCompletionRequest, | ||
ErrorResponse, LogProbs, | ||
ModelCard, ModelList, | ||
ModelPermission) | ||
ModelPermission, DeleteResponse) | ||
from vllm.lora.request import LoRARequest | ||
from vllm.sequence import Logprob | ||
|
||
|
@@ -84,6 +84,38 @@ async def show_available_models(self) -> ModelList: | |
model_cards.extend(lora_cards) | ||
return ModelList(data=model_cards) | ||
|
||
|
||
async def add_lora(self, lora: LoRA) -> ModelCard: | ||
last_lora_request: LoRARequest = self.lora_requests.get(self.lora_requests.size() - 1) | ||
lora_idx = 1 | ||
if last_lora_request is not None: | ||
lora_idx = last_lora_request.lora_int_id + 1 | ||
|
||
self.lora_requests.append(LoRARequest( | ||
lora_name=lora.name, | ||
lora_int_id=lora_idx, | ||
lora_local_path=lora.local_path, | ||
)) | ||
|
||
return ModelCard(id=lora.lora_name, | ||
root=self.served_model, | ||
permission=[ModelPermission()]) | ||
|
||
async def delete_lora(self, model: str) -> DeleteResponse: | ||
if model == self.served_model: | ||
raise ValueError("Unsupported delete operation, base model delete not supported") | ||
|
||
lora_idx = -1 | ||
for idx, lora in enumerate(self.lora_requests): | ||
if model == lora.lora_name: | ||
lora_idx = idx | ||
if lora_idx != -1: | ||
lora = self.lora_requests.pop(lora_idx) | ||
return DeleteResponse(id=lora.lora_name, | ||
deleted=True) | ||
Comment on lines
+108
to
+115
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see above - incrementing and decrementing the counter is brittle |
||
|
||
raise ValueError(f"The model {model} does not exist.") | ||
|
||
def _create_logprobs( | ||
self, | ||
token_ids: List[int], | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's have an increment only counter for LoRA ids instead?
also, is it possible to check if the lora has already been added before? we can use the local_path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay, I will be active on this now; I will resume work here.