Dynamic Multi LoRA Load \ Delete Support #3496
Conversation
| last_lora_request: LoRARequest = self.lora_requests.get(self.lora_requests.size() - 1) | ||
| lora_idx = 1 | ||
| if last_lora_request is not None: | ||
| lora_idx = last_lora_request.lora_int_id + 1 | ||
|
|
||
| self.lora_requests.append(LoRARequest( | ||
| lora_name=lora.name, | ||
| lora_int_id=lora_idx, | ||
| lora_local_path=lora.local_path, | ||
| )) |
There was a problem hiding this comment.
let's have an increment only counter for LoRA ids instead?
also, is it possible to check if the lora has already been added before? we can use the local_path
There was a problem hiding this comment.
sorry for the delay, I will be active on this now; I will resume work here.
| lora_idx = -1 | ||
| for idx, lora in enumerate(self.lora_requests): | ||
| if model == lora.lora_name: | ||
| lora_idx = idx | ||
| if lora_idx != -1: | ||
| lora = self.lora_requests.pop(lora_idx) | ||
| return DeleteResponse(id=lora.lora_name, | ||
| deleted=True) |
There was a problem hiding this comment.
see above - incrementing and decrementing the counter is brittle
|
Hi @gauravkr2108, sorry about the delay, please address @Yard1's comment. |
|
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
|
This pull request has merge conflicts that must be resolved before it can be |
FILL IN THE PR DESCRIPTION HERE
FIX #3308
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]For changes on the vLLM frontend (e.g., OpenAI API server,LLMclass, etc.)[Kernel]for changes affecting CUDA kernels or other compute kernels.[Core]for changes in the core vLLM logic (e.g.,LLMEngine,AsyncLLMEngine,Scheduler, etc.)[Hardware][Vendor]for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.shto format your code.docs/source/if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-requiredand might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-requiredlabel on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!