Revert "Use NVCC --compress-mode to reduce binary size by 30% #20694" #20853
Conversation
…oject#20694" Signed-off-by: mgoin <mgoin64@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mgoin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses critical issues reported after the introduction of NVCC fatbin compression. My primary goal is to revert the changes that enabled these compression flags, thereby resolving the reported kernel support breakage. This ensures the stability and compatibility of the build system, prioritizing functionality over binary size optimization for now.
Highlights
- Reversion of NVCC Compression: I have reverted the previous change that enabled NVCC fatbin compression flags (
-Xfatbin,-compress-all,-compress-mode=size) withinCMakeLists.txt. This change was originally introduced to reduce binary size but has led to reports of breaking kernel support.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request reverts a change that enabled NVCC fatbin compression due to reports of it breaking kernel support. The modification in CMakeLists.txt correctly removes the code block responsible for adding the compression flags. The revert appears to be clean and complete based on the provided diff. I have reviewed the changes and found no issues.
…oject#20694" (vllm-project#20853) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: x22x22 <wadeking@qq.com>
…oject#20694" (vllm-project#20853) Signed-off-by: mgoin <mgoin64@gmail.com>
…oject#20694" (vllm-project#20853) Signed-off-by: mgoin <mgoin64@gmail.com>
…oject#20694" (vllm-project#20853) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…oject#20694" (vllm-project#20853) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…oject#20694" (vllm-project#20853) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…oject#20694" (vllm-project#20853) Signed-off-by: mgoin <mgoin64@gmail.com>
4 participants
Purpose
There are several reports of this change (#20694) breaking kernel support, so we must revert this for now
FIX #20832 #20847
Test Plan
Test Result