Skip to content

[Bugfix]: import pandas for benchmarks #19079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ZhangShuaiyi
Copy link

@ZhangShuaiyi ZhangShuaiyi commented Jun 3, 2025

FIX #19078

VLLM_USE_PRECOMPILED=1 uv pip install --editable ., pandas (introduced in #18511) is not installed.

Signed-off-by: Shuaiyi Zhang <zhangsy28@lenovo.com>
@mergify mergify bot added the ci/build label Jun 3, 2025
@ZhangShuaiyi
Copy link
Author

cc @ekagra-ranjan @ywang96

Copy link

github-actions bot commented Jun 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ZhangShuaiyi ZhangShuaiyi force-pushed the fix_benchmark_requirement branch from 3e746cb to df052b5 Compare June 3, 2025 12:04
@Isotr0py
Copy link
Collaborator

Isotr0py commented Jun 3, 2025

Thanks for your contribution! Since there are also other packages like datasets introduced for benchmark only, I think it would be better to make them as extra dependency (#19089). So that user can install them only when having demands for benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ModuleNotFoundError: No module named 'pandas'
2 participants