-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[Misc][Benchmark] Add support for CustomDataset #18511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM and I left a comment! Can you also update the benchmark readme to include this dataset? Thanks!
@ywang96 - all done! Pls have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 @ekagra-ranjan Thank you for the contribution!
There is 1 failure in V1 test which is blocking merge
I dont think its caused by this PR. Could be related to this. @ywang96 - what are your thoughts? |
@ekagra-ranjan I've merged this branch from main so let's see if it helps! |
Signed-off-by: amit <amit.man@gmail.com>
Signed-off-by: amit <amit.man@gmail.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
Fixes: #14036 (review) and #18509
Currently, online serving benchmark only loads some specified dataset. This PR adds support for CustomDataset which can load arbitrary datasets for benchmarking. It accepts dataset in jsonl format and can be extended to other format since it converts the input data to into a standardized format of list of dictionary in
load_data()
which then is used insample()
.Example is given in the comment of the function.
Usage
example of data.jsonl
cc: @ywang96