Skip to content

[Qwen3 Next] Update qwen3_next to use moe_calibration_context #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 3, 2025
Merged

[Qwen3 Next] Update qwen3_next to use moe_calibration_context #1984

merged 9 commits into from
Nov 3, 2025
+140 −14

Conversation

@dsikka
Copy link
Collaborator

@dsikka dsikka commented Oct 30, 2025 •
edited
Loading

SUMMARY:

  • Update the qwen3_next_moe definition to use the moe context
  • Update example to use the correct arguement
  • Add tests
  • Update qwen3_moe model definition to implement restore

Testing:

  • All modeling tests pass

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@dsikka dsikka mentioned this pull request Oct 30, 2025
Closed
@dsikka dsikka added the ready When a PR is ready for review label Oct 30, 2025
@dsikka dsikka added qwen For any PR / issue related to Qwen support nvfp4 For any PR / issue related to NVFP4 support labels Oct 30, 2025
kylesayrs
kylesayrs reviewed Oct 30, 2025
View reviewed changes
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@dsikka
Copy link
Collaborator Author

dsikka commented Oct 30, 2025

Tests?

I'll add. Running basic evals on vLLM to start

@dsikka dsikka marked this pull request as ready for review October 31, 2025 15:56
@dsikka dsikka requested a review from kylesayrs October 31, 2025 16:03
@dsikka dsikka enabled auto-merge (squash) November 1, 2025 05:08
@HDCharles HDCharles self-requested a review November 3, 2025 19:00
@HDCharles HDCharles mentioned this pull request Nov 3, 2025
Open
HDCharles
HDCharles reviewed Nov 3, 2025
View reviewed changes
HDCharles
HDCharles approved these changes Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@HDCharles HDCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

kylesayrs
kylesayrs approved these changes Nov 3, 2025
View reviewed changes
@dsikka dsikka merged commit ee755a4 into main Nov 3, 2025
9 checks passed
@dsikka dsikka deleted the fix_qwen3 branch November 3, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylesayrs kylesayrs kylesayrs approved these changes

@HDCharles HDCharles HDCharles approved these changes

Assignees

No one assigned

Labels

nvfp4 For any PR / issue related to NVFP4 support qwen For any PR / issue related to Qwen support ready When a PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dsikka @kylesayrs @HDCharles