[Fix] Disable GGA in NIXL samples #1436
Conversation
Explicitly set UCX_TLS to let UCX not use GGA (GPU Direct) transport Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @DwyaneShi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue in NIXL samples by modifying several YAML configuration files. The core change involves explicitly setting the UCX_TLS environment variable to prevent UCX from using GPU Direct Access (GGA) transport. This adjustment aims to resolve potential compatibility or performance problems by ensuring UCX relies on other communication mechanisms, thereby stabilizing the sample executions.
Highlights
- UCX Configuration: The
UCX_TLSenvironment variable has been added to various sample YAML configurations. This variable is set to^gga, which explicitly disables GPU Direct Access (GGA) transport for UCX, ensuring that UCX utilizes alternative transport layers.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a fix for NIXL samples by explicitly setting the UCX_TLS environment variable to prevent UCX from using the GGA (GPU Direct) transport. The change is applied consistently across multiple sample and test YAML files. My feedback focuses on improving the YAML syntax for clarity and consistency by quoting the new environment variable's value. This is a good practice that aligns with how other values are defined in these files.
| @@ -71,6 +71,8 @@ spec: | |||
| value: "7" | |||
| - name: NCCL_DEBUG | |||
| value: "INFO" | |||
| - name: UCX_TLS | |||
| value: ^gga | |||
There was a problem hiding this comment.
For consistency and to prevent any potential parsing issues, it's good practice to quote string values in YAML, especially when they contain special characters like ^. Most other string values in this file are already quoted.
value: "^gga"
| @@ -148,6 +150,8 @@ spec: | |||
| value: "7" | |||
| - name: NCCL_DEBUG | |||
| value: "INFO" | |||
| - name: UCX_TLS | |||
| value: ^gga | |||
There was a problem hiding this comment.
For consistency and to prevent any potential parsing issues, it's good practice to quote string values in YAML, especially when they contain special characters like ^. Most other string values in this file are already quoted.
value: "^gga"
| @@ -71,6 +71,8 @@ spec: | |||
| value: "7" | |||
| - name: NCCL_DEBUG | |||
| value: "INFO" | |||
| - name: UCX_TLS | |||
| value: ^gga | |||
There was a problem hiding this comment.
For consistency and to prevent any potential parsing issues, it's good practice to quote string values in YAML, especially when they contain special characters like ^. Most other string values in this file are already quoted.
value: "^gga"
| @@ -148,6 +150,8 @@ spec: | |||
| value: "7" | |||
| - name: NCCL_DEBUG | |||
| value: "INFO" | |||
| - name: UCX_TLS | |||
| value: ^gga | |||
There was a problem hiding this comment.
For consistency and to prevent any potential parsing issues, it's good practice to quote string values in YAML, especially when they contain special characters like ^. Most other string values in this file are already quoted.
value: "^gga"
| @@ -71,6 +71,8 @@ spec: | |||
| value: "7" | |||
| - name: NCCL_DEBUG | |||
| value: "INFO" | |||
| - name: UCX_TLS | |||
| value: ^gga | |||
There was a problem hiding this comment.
For consistency and to prevent any potential parsing issues, it's good practice to quote string values in YAML, especially when they contain special characters like ^. Most other string values in this file are already quoted.
value: "^gga"
| @@ -148,6 +150,8 @@ spec: | |||
| value: "7" | |||
| - name: NCCL_DEBUG | |||
| value: "INFO" | |||
| - name: UCX_TLS | |||
| value: ^gga | |||
There was a problem hiding this comment.
For consistency and to prevent any potential parsing issues, it's good practice to quote string values in YAML, especially when they contain special characters like ^. Most other string values in this file are already quoted.
value: "^gga"
| @@ -62,6 +62,8 @@ spec: | |||
| value: "7" | |||
| - name: NCCL_DEBUG | |||
| value: "INFO" | |||
| - name: UCX_TLS | |||
| value: ^gga | |||
There was a problem hiding this comment.
For consistency and to prevent any potential parsing issues, it's good practice to quote string values in YAML, especially when they contain special characters like ^. Most other string values in this file are already quoted.
value: "^gga"
| @@ -117,6 +119,8 @@ spec: | |||
| value: "7" | |||
| - name: NCCL_DEBUG | |||
| value: "INFO" | |||
| - name: UCX_TLS | |||
| value: ^gga | |||
There was a problem hiding this comment.
For consistency and to prevent any potential parsing issues, it's good practice to quote string values in YAML, especially when they contain special characters like ^. Most other string values in this file are already quoted.
value: "^gga"
| @@ -67,6 +67,8 @@ spec: | |||
| value: "7" | |||
| - name: NCCL_DEBUG | |||
| value: "INFO" | |||
| - name: UCX_TLS | |||
| value: ^gga | |||
There was a problem hiding this comment.
For consistency and to prevent any potential parsing issues, it's good practice to quote string values in YAML, especially when they contain special characters like ^. Most other string values in this file are already quoted.
value: "^gga"
| @@ -140,6 +142,8 @@ spec: | |||
| value: "7" | |||
| - name: NCCL_DEBUG | |||
| value: "INFO" | |||
| - name: UCX_TLS | |||
| value: ^gga | |||
There was a problem hiding this comment.
For consistency and to prevent any potential parsing issues, it's good practice to quote string values in YAML, especially when they contain special characters like ^. Most other string values in this file are already quoted.
value: "^gga"
Jeffwan
changed the title
Jeffwan
changed the title
[Fix] Fix NIXL samples Explicitly set UCX_TLS to let UCX not use GGA (GPU Direct) transport Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com> Co-authored-by: Haiyang Shi <haiyang.shi@bytedance.com>
…se-0.4 branch (#1468) * Select PD workers in same roleset (#1409) * Select PD workers in same roleset * nit * update ut --------- Signed-off-by: Varun Gupta <varungup90@gmail.com> * [Bug] fix webhook config output when using make manifests (#1412) fix webhook config output when using make manifests Signed-off-by: googs1025 <googs1025@gmail.com> * [Fix] Fix vLLM NIXL-based P/D samples (#1425) Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com> Co-authored-by: Haiyang Shi <haiyang.shi@bytedance.com> * [Fix] Disable GGA in NIXL samples (#1436) [Fix] Fix NIXL samples Explicitly set UCX_TLS to let UCX not use GGA (GPU Direct) transport Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com> Co-authored-by: Haiyang Shi <haiyang.shi@bytedance.com> * Fix P/D disaggregation router to follow Nixl kv_transfer_params (#1429) - Add kv_transfer_params configuration to prefill requests and decode requests Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> * [Bug] Corrected naming convention for AIBRIX_MODEL_GPU_PROFILE_CACHING_FLAG (#1427) Corrected naming convention for AIBRIX_MODEL_GPU_PROFILE_CACHING_FLAG Signed-off-by: Jonathon Shea <sheajonathon0@gmail.com> * [Bug] stormservice's headless service not set ownerRef (#1442) * fix: stormservice's headless service not set ownerRef Signed-off-by: dajun.cui <dajun.cui@bytedance.com> * fix: patch ut test for service sync Signed-off-by: dajun.cui <dajun.cui@bytedance.com> --------- Signed-off-by: dajun.cui <dajun.cui@bytedance.com> * [Bug] stormservice's headless service need set PublishNotReadyAddresses (#1441) * fix: stormservice's headless service need set PublishNotReadyAddresses Signed-off-by: dajun.cui <dajun.cui@bytedance.com> * fix: isServiceEqual check PublishNotReadyAddresses Signed-off-by: dajun.cui <dajun.cui@bytedance.com> --------- Signed-off-by: dajun.cui <dajun.cui@bytedance.com> --------- Signed-off-by: Varun Gupta <varungup90@gmail.com> Signed-off-by: googs1025 <googs1025@gmail.com> Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com> Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> Signed-off-by: Jonathon Shea <sheajonathon0@gmail.com> Signed-off-by: dajun.cui <dajun.cui@bytedance.com> Co-authored-by: Varun Gupta <varungup90@gmail.com> Co-authored-by: CYJiang <86391540+googs1025@users.noreply.github.com> Co-authored-by: Haiyang Shi <dwyane.shi@gmail.com> Co-authored-by: Haiyang Shi <haiyang.shi@bytedance.com> Co-authored-by: Jonathon Shea <35823125+JonathonShea@users.noreply.github.com> Co-authored-by: cuidajun <dajun.cui@bytedance.com>
Pull Request Description
Explicitly set UCX_TLS to let UCX not use GGA (GPU Direct) transport
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.