[Bug] fix webhook config output when using make manifests #1412
Conversation
Signed-off-by: googs1025 <googs1025@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @googs1025, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in the webhook configuration generation process, specifically when using make manifests. It corrects misconfigurations in the Kubernetes webhook manifests and the corresponding Go source code to ensure proper validation behavior for modeladapter and kvcache resources.
Highlights
- Webhook Configuration Correction: Corrected the
manifests.yamlto properly associate webhook paths, names, API groups, and resources formodeladapterandkvcachevalidation, which were previously swapped. - KVCache Webhook Type Fix: Updated the
KVCachewebhook definition in its Go source file to correctly identify it as a validating webhook (mutating=false) rather than a mutating one.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| @@ -81,7 +81,7 @@ func (d *KVCacheCustomDefaulter) Default(_ context.Context, obj runtime.Object) | |||
| // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation. | |||
| // NOTE: The 'path' attribute must follow a specific pattern and should not be modified directly here. | |||
| // Modifying the path for an invalid path can cause API server errors; failing to locate the webhook. | |||
| // +kubebuilder:webhook:path=/validate-orchestration-aibrix-ai-v1alpha1-kvcache,mutating=true,failurePolicy=fail,sideEffects=None,groups=orchestration.aibrix.ai,resources=kvcaches,verbs=create;update,versions=v1alpha1,name=vkvcache-v1alpha1.kb.io,admissionReviewVersions=v1 | |||
| // +kubebuilder:webhook:path=/validate-orchestration-aibrix-ai-v1alpha1-kvcache,mutating=false,failurePolicy=fail,sideEffects=None,groups=orchestration.aibrix.ai,resources=kvcaches,verbs=create;update,versions=v1alpha1,name=vkvcache-v1alpha1.kb.io,admissionReviewVersions=v1 | |||
No longer reoccurs after changing 🤔 |
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the KVCache webhook configuration. By changing the mutating flag from true to false for the KVCacheCustomValidator, you ensure that the validating webhook is correctly registered and executed in the proper admission control phase. The update to the generated manifests.yaml file reflects this correction. The change is small but important for the correctness of the webhook behavior.
| @@ -81,7 +81,7 @@ func (d *KVCacheCustomDefaulter) Default(_ context.Context, obj runtime.Object) | |||
| // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation. | |||
| // NOTE: The 'path' attribute must follow a specific pattern and should not be modified directly here. | |||
| // Modifying the path for an invalid path can cause API server errors; failing to locate the webhook. | |||
| // +kubebuilder:webhook:path=/validate-orchestration-aibrix-ai-v1alpha1-kvcache,mutating=true,failurePolicy=fail,sideEffects=None,groups=orchestration.aibrix.ai,resources=kvcaches,verbs=create;update,versions=v1alpha1,name=vkvcache-v1alpha1.kb.io,admissionReviewVersions=v1 | |||
| // +kubebuilder:webhook:path=/validate-orchestration-aibrix-ai-v1alpha1-kvcache,mutating=false,failurePolicy=fail,sideEffects=None,groups=orchestration.aibrix.ai,resources=kvcaches,verbs=create;update,versions=v1alpha1,name=vkvcache-v1alpha1.kb.io,admissionReviewVersions=v1 | |||
There was a problem hiding this comment.
This change is crucial for correctness. A validating webhook, such as KVCacheCustomValidator, must have mutating=false.
The previous mutating=true setting was a significant bug. It would cause controller-gen to mis-categorize this validator as a mutating webhook, leading the Kubernetes API server to invoke it during the wrong phase of the admission control process.
This fix ensures the webhook is correctly registered within a ValidatingWebhookConfiguration and executed during the validation phase, after all object mutations are complete. Great catch!
|
@Jeffwan /PTAL |
…ct#1412) fix webhook config output when using make manifests Signed-off-by: googs1025 <googs1025@gmail.com>
…se-0.4 branch (#1468) * Select PD workers in same roleset (#1409) * Select PD workers in same roleset * nit * update ut --------- Signed-off-by: Varun Gupta <varungup90@gmail.com> * [Bug] fix webhook config output when using make manifests (#1412) fix webhook config output when using make manifests Signed-off-by: googs1025 <googs1025@gmail.com> * [Fix] Fix vLLM NIXL-based P/D samples (#1425) Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com> Co-authored-by: Haiyang Shi <haiyang.shi@bytedance.com> * [Fix] Disable GGA in NIXL samples (#1436) [Fix] Fix NIXL samples Explicitly set UCX_TLS to let UCX not use GGA (GPU Direct) transport Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com> Co-authored-by: Haiyang Shi <haiyang.shi@bytedance.com> * Fix P/D disaggregation router to follow Nixl kv_transfer_params (#1429) - Add kv_transfer_params configuration to prefill requests and decode requests Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> * [Bug] Corrected naming convention for AIBRIX_MODEL_GPU_PROFILE_CACHING_FLAG (#1427) Corrected naming convention for AIBRIX_MODEL_GPU_PROFILE_CACHING_FLAG Signed-off-by: Jonathon Shea <sheajonathon0@gmail.com> * [Bug] stormservice's headless service not set ownerRef (#1442) * fix: stormservice's headless service not set ownerRef Signed-off-by: dajun.cui <dajun.cui@bytedance.com> * fix: patch ut test for service sync Signed-off-by: dajun.cui <dajun.cui@bytedance.com> --------- Signed-off-by: dajun.cui <dajun.cui@bytedance.com> * [Bug] stormservice's headless service need set PublishNotReadyAddresses (#1441) * fix: stormservice's headless service need set PublishNotReadyAddresses Signed-off-by: dajun.cui <dajun.cui@bytedance.com> * fix: isServiceEqual check PublishNotReadyAddresses Signed-off-by: dajun.cui <dajun.cui@bytedance.com> --------- Signed-off-by: dajun.cui <dajun.cui@bytedance.com> --------- Signed-off-by: Varun Gupta <varungup90@gmail.com> Signed-off-by: googs1025 <googs1025@gmail.com> Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com> Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> Signed-off-by: Jonathon Shea <sheajonathon0@gmail.com> Signed-off-by: dajun.cui <dajun.cui@bytedance.com> Co-authored-by: Varun Gupta <varungup90@gmail.com> Co-authored-by: CYJiang <86391540+googs1025@users.noreply.github.com> Co-authored-by: Haiyang Shi <dwyane.shi@gmail.com> Co-authored-by: Haiyang Shi <haiyang.shi@bytedance.com> Co-authored-by: Jonathon Shea <35823125+JonathonShea@users.noreply.github.com> Co-authored-by: cuidajun <dajun.cui@bytedance.com>
Pull Request Description
[Please provide a clear and concise description of your changes here]
Related Issues
Resolves: #1408 (comment)
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.