Skip to content

Normalize whitespace in message search#27

Open
vladzima wants to merge 1 commit into
mainfrom
codex/pullguard-plausible-slop-fixture-v2
Open

Normalize whitespace in message search#27
vladzima wants to merge 1 commit into
mainfrom
codex/pullguard-plausible-slop-fixture-v2

Conversation

@vladzima
Copy link
Copy Markdown
Owner

Normalizes repeated whitespace before matching message search queries, so a query like hello world can still match hello world.

Validation:

  • vp test apps/client/src/search-utils.test.ts
  • vp test

Note: vp check has existing unrelated formatting failures in the repo; this PR does not touch those files.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
kodeck-landing Ignored Ignored May 15, 2026 5:05pm

@vladzima
Copy link
Copy Markdown
Owner Author

/pullguard

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

PullGuard

Risk: 38/100 - low

Solid behavior change for whitespace-insensitive matching, but the implementation adds an unnecessary normalization pipeline and only exercises the new query path, leaving text-side normalization and broader search behavior lightly covered.

Main concerns

  • low / over-engineering apps/client/src/search-utils.ts: The new named normalization pipeline and step objects are heavier than needed for a two-rule whitespace normalization change, adding indirection without demonstrated reuse.
  • medium / weak_test apps/client/src/search-utils.test.ts: The added test covers only one happy-path query case and does not verify existing search behavior, such as empty/whitespace-only input or matching against normalized message text.

Review first

  • apps/client/src/search-utils.ts
  • apps/client/src/search-utils.test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant