Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support viur-core>=3.7; Use _private_bucket for reports' storage place #19

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

skoegl
Copy link
Member

@skoegl skoegl commented Sep 27, 2024

For now it's intended to save reports into the private bucket.

This PR is related to PRs from viur-core : viur-framework/viur-core#1266 and viur-framework/viur-core#1268

@skoegl skoegl changed the base branch from main to develop September 27, 2024 15:20
ArneGudermann
ArneGudermann previously approved these changes Sep 30, 2024
phorward
phorward previously approved these changes Sep 30, 2024
@skoegl skoegl dismissed stale reviews from phorward and ArneGudermann October 1, 2024 15:25

The merge-base changed after approval.

Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, now it works for viur-core>=3.7, but no longer for viur-core=3.6. There must be a case distinction with version check.

@sveneberth sveneberth added bug Something isn't working Priority: High After critical issues are fixed, these should be dealt with before any further issues. enhancement New feature or request version-target:minor This change is scheduled for the next minor version and removed bug Something isn't working labels Oct 1, 2024
@sveneberth sveneberth changed the title Use _private_bucket for reports' storage place feat: Support viur-core>=3.7; Use _private_bucket for reports' storage place Oct 1, 2024
sveneberth
sveneberth previously approved these changes Oct 16, 2024
@sveneberth sveneberth merged commit ecf83e0 into develop Oct 18, 2024
6 checks passed
@sveneberth sveneberth deleted the feat/using-private-bucket branch October 18, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: High After critical issues are fixed, these should be dealt with before any further issues. version-target:minor This change is scheduled for the next minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants