-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support viur-core>=3.7
; Use _private_bucket
for reports' storage place
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneGudermann
previously approved these changes
Sep 30, 2024
phorward
previously approved these changes
Sep 30, 2024
skoegl
dismissed stale reviews from phorward and ArneGudermann
October 1, 2024 15:25
The merge-base changed after approval.
sveneberth
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, now it works for viur-core>=3.7, but no longer for viur-core=3.6. There must be a case distinction with version check.
sveneberth
added
bug
Something isn't working
Priority: High
After critical issues are fixed, these should be dealt with before any further issues.
enhancement
New feature or request
version-target:minor
This change is scheduled for the next minor version
and removed
bug
Something isn't working
labels
Oct 1, 2024
sveneberth
changed the title
Use _private_bucket for reports' storage place
feat: Support Oct 1, 2024
viur-core>=3.7
; Use _private_bucket
for reports' storage place
sveneberth
previously approved these changes
Oct 16, 2024
sveneberth
approved these changes
Oct 16, 2024
phorward
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Priority: High
After critical issues are fixed, these should be dealt with before any further issues.
version-target:minor
This change is scheduled for the next minor version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now it's intended to save reports into the private bucket.
This PR is related to PRs from viur-core : viur-framework/viur-core#1266 and viur-framework/viur-core#1268