Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle gracefully downloadurls and srcsets with optional languages overwrite for files #1266

Merged
merged 7 commits into from
Sep 30, 2024
Merged

fix: handle gracefully downloadurls and srcsets with optional languages overwrite for files #1266

merged 7 commits into from
Sep 30, 2024

Conversation

skoegl
Copy link
Member

@skoegl skoegl commented Sep 24, 2024

See #1265

@skoegl skoegl linked an issue Sep 24, 2024 that may be closed by this pull request
downloadUrlFor and srcSetFor for FileBone with languages are not handled correctly #1265
Closed
phorward
phorward requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@phorward phorward left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @skoegl, thanks for creating this pull request.
Can you please test my suggested changes and apply it to the case below as well?

src/viur/core/modules/file.py Outdated Show resolved Hide resolved
src/viur/core/modules/file.py Outdated Show resolved Hide resolved
src/viur/core/render/html/env/viur.py Outdated Show resolved Hide resolved
src/viur/core/render/html/env/viur.py Outdated Show resolved Hide resolved
src/viur/core/render/html/env/viur.py Outdated Show resolved Hide resolved
skoegl added a commit that referenced this pull request Sep 24, 2024
@skoegl
* additional test issue #1265 and pr #1266 against viur-core 3.7.0.dev2
4011b76
skoegl and others added 4 commits September 24, 2024 23:20
@skoegl @phorward
Update src/viur/core/modules/file.py
2928d76 
Co-authored-by: Jan Max Meyer <jmm@phorward.de>
@skoegl @phorward
Update src/viur/core/modules/file.py
a70128d 
Co-authored-by: Jan Max Meyer <jmm@phorward.de>
@skoegl @phorward
Update src/viur/core/render/html/env/viur.py
8b178e9 
Co-authored-by: Jan Max Meyer <jmm@phorward.de>
@skoegl @phorward
Update src/viur/core/render/html/env/viur.py
9608083 
Co-authored-by: Jan Max Meyer <jmm@phorward.de>
@phorward phorward added this to the ViUR-core v3.7 milestone Sep 24, 2024
@phorward phorward added the bug(fix) Something isn't working or address a specific issue or vulnerability label Sep 24, 2024
@skoegl
Copy link
Member Author

skoegl commented Sep 27, 2024

Thank you for the code review . I hopefully have completed all requested changes. Please take another look and if ok, please merge.

@skoegl skoegl mentioned this pull request Sep 27, 2024
Merged
@phorward phorward merged commit 6b80c83 into develop Sep 30, 2024
8 checks passed
@phorward phorward deleted the fix/files-multiple-languages-downloadurl-srcset branch September 30, 2024 18:50
@phorward phorward mentioned this pull request Sep 30, 2024
Closed
sveneberth added a commit to viur-framework/viur-toolkit that referenced this pull request Oct 18, 2024
@skoegl @sveneberth
feat: Support viur-core>=3.7; Use _private_bucket for reports' st…
ecf83e0 
…orage place (#19)

For now it's intended to save reports into the private bucket.

This PR is related to PRs from viur-core :
viur-framework/viur-core#1266 and
viur-framework/viur-core#1268

---------

Co-authored-by: Sven Eberth <mail@sveneberth.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phorward phorward phorward approved these changes

Assignees
No one assigned
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability
Projects
Documentation
Status: Todo
Milestone
ViUR-core v3.7
Development

Successfully merging this pull request may close these issues.

downloadUrlFor and srcSetFor for FileBone with languages are not handled correctly
2 participants
@skoegl @phorward