Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement abstract renderer #1190

Merged
merged 2 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adjust __init__ methods
  • Loading branch information
sveneberth committed Jun 14, 2024
commit 5956df92b14d2d3f70313120dda2f3643de51b3f
1 change: 1 addition & 0 deletions src/viur/core/render/abstract.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def __init__(self, parent: Module = None):
@property
@abc.abstractmethod
def kind(self) -> str:
"""Renderer type specifier"""
...

@abc.abstractmethod
Expand Down
5 changes: 2 additions & 3 deletions src/viur/core/render/html/default.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,13 @@ class Render(AbstractRenderer):

__haveEnvImported_ = False

def __init__(self, parent=None, *args, **kwargs):
super(Render, self).__init__(*args, **kwargs)
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
if not Render.__haveEnvImported_:
# We defer loading our plugins to this point to avoid circular imports
# noinspection PyUnresolvedReferences
from . import env
Render.__haveEnvImported_ = True
self.parent = parent

def getTemplateFileName(
self,
Expand Down
4 changes: 0 additions & 4 deletions src/viur/core/render/json/default.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ def default(self, o: t.Any) -> t.Any:
class DefaultRender(AbstractRenderer):
kind = "json"

def __init__(self, parent=None, *args, **kwargs):
super(DefaultRender, self).__init__(*args, **kwargs)
self.parent = parent

@staticmethod
def render_structure(structure: dict):
"""
Expand Down
4 changes: 0 additions & 4 deletions src/viur/core/render/xml/default.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ def recursiveSerializer(data, element):
class DefaultRender(AbstractRenderer):
kind = "xml"

def __init__(self, parent=None, *args, **kwargs):
super(DefaultRender, self).__init__(*args, **kwargs)


def renderTextExtension(self, ext):
e = ext()
return ({"name": e.name,
Expand Down
Loading