Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement abstract renderer #1190

Merged
merged 2 commits into from
Jun 17, 2024
Merged

feat: Implement abstract renderer #1190

merged 2 commits into from
Jun 17, 2024

Conversation

sveneberth
Copy link
Member

Resolves #1163

@sveneberth sveneberth added feature New feature or request refactoring Pull requests that refactor code but do not change its behavior. python Pull requests that update Python code labels Jun 14, 2024
@sveneberth sveneberth linked an issue Jun 14, 2024 that may be closed by this pull request
Add abstract / base class for all renderers #1163
Closed
phorward
phorward approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@phorward phorward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we can drop the XML renderer, as it can be re-implemented easily with planned changes coming soon regarding the json-renderer. (see #1071, part of ActionSkel-paradigm)

@phorward phorward merged commit ceea568 into viur-framework:develop Jun 17, 2024
3 checks passed
@sveneberth sveneberth deleted the feature/abstract_renderer branch July 9, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArneGudermann ArneGudermann ArneGudermann approved these changes

@phorward phorward phorward approved these changes

Assignees
No one assigned
Labels
feature New feature or request python Pull requests that update Python code refactoring Pull requests that refactor code but do not change its behavior.
Projects
Documentation
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add abstract / base class for all renderers
3 participants
@sveneberth @phorward @ArneGudermann