refactor: Sub-class Session from db.Entity to behave dict-compliant
#1153
Conversation
There was a problem hiding this comment.
Hello @KadirBalku, thanks for your first pull request!
I've added some improvement suggestions.
Can you test your branch with other projects than "viur-trial" please, just for confidence.
phorward
added
the
refactoring
phorward
added
the
Priority: Medium
phorward
changed the title
Session from db.Entity to behave dict-compliant
Co-authored-by: Jan Max Meyer <jmm@phorward.de>
Co-authored-by: Jan Max Meyer <jmm@phorward.de>
There was a problem hiding this comment.
Hello @KadirBalku,
have you tested it with other projects?
And can you please take a look at the functions I've commented. Maybe they must be kept, or the internally use __setitem__. In latter case, all is fine, and the changed-flag is being set properly.
Take a look into the Python docs to get an overview about all dict-related functions.
There was a problem hiding this comment.
@KadirBalku looks good to me!
Please fix the unused import issue, then we can merge.
There was a problem hiding this comment.
What about Session.pop() and where is Session.setdefault() from #1140?
@KadirBalku |
In the viur-meeting on 2024-04-12, it was decided to change the licensing terms of the viur-core component from the LGPL-v3 into the MIT license. This pull request updates all relevant parts of the codebase. --------- Co-authored-by: Sven Eberth <mail@sveneberth.de>
|
@KadirBalku we should discuss about dropping Python 3.10 support with viur-core>=3.7 |
Co-authored-by: Sven Eberth <mail@sveneberth.de>
|
I removed python3.10 support as decided in the viur-meeting today. After we merged that we can merge this pr whithout a failing pipeline |
Resolves #1147, replaces #1140.