Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat Add session setdefault #1140

Merged
merged 3 commits into from
Apr 29, 2024
Merged

feat Add session setdefault #1140

merged 3 commits into from
Apr 29, 2024

Conversation

ArneGudermann
Copy link
Contributor

@ArneGudermann ArneGudermann added feature New feature or request Priority: Low This issue can be considered with enough idle time. labels Apr 11, 2024
@ArneGudermann ArneGudermann added this to the ViUR-core v3.7 milestone Apr 11, 2024
@ArneGudermann ArneGudermann changed the base branch from main to develop April 11, 2024 08:51
sveneberth
sveneberth requested changes Apr 12, 2024
View reviewed changes
src/viur/core/session.py Outdated Show resolved Hide resolved
@ArneGudermann @sveneberth
Update src/viur/core/session.py
59abbf8 
Co-authored-by: Sven Eberth <mail@sveneberth.de>
phorward
phorward approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@phorward phorward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay for me. We generally should think about subclassing Session from db.Entity, which is a subclass of dict, so that the session can be used like an ordinary dict in all situations.

@phorward phorward mentioned this pull request Apr 29, 2024
Closed
@phorward phorward merged commit 3c87354 into viur-framework:develop Apr 29, 2024
3 checks passed
@sveneberth sveneberth deleted the feat/session_setdefault branch April 30, 2024 10:12
@phorward phorward mentioned this pull request May 6, 2024
Merged
phorward added a commit that referenced this pull request May 28, 2024
@KadirBalku @phorward @sveneberth
refactor: Sub-class Session from db.Entity to behave dict-compl…
56f110b 
…iant (#1153)

Resolves #1147, replaces #1140.

---------

Co-authored-by: Jan Max Meyer <jmm@phorward.de>
Co-authored-by: Sven Eberth <mail@sveneberth.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phorward phorward phorward approved these changes

@sveneberth sveneberth sveneberth approved these changes

Assignees
No one assigned
Labels
feature New feature or request Priority: Low This issue can be considered with enough idle time.
Projects
Documentation
Status: Todo
Milestone
ViUR-core v3.7
Development

Successfully merging this pull request may close these issues.
3 participants
@ArneGudermann @sveneberth @phorward