Skip to content

fix(reporters): prevent yellow dots in dot reporter when all tests pass #9720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pierreeurope wants to merge 1 commit into from
Closed

fix(reporters): prevent yellow dots in dot reporter when all tests pass #9720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/vitest/src/node/reporters/dot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export class DotReporter extends BaseReporter {

onWatcherRerun(files: string[], trigger?: string): void {
this.tests.clear()
this.finishedTests.clear()
this.renderer?.start()
super.onWatcherRerun(files, trigger)
}
Expand Down Expand Up @@ -111,7 +112,7 @@ export class DotReporter extends BaseReporter {
return
}

const finishedTests = Array.from(this.tests).filter(entry => entry[1] !== 'pending')
const finishedTests = Array.from(this.tests).filter(([id]) => this.finishedTests.has(id))

if (finishedTests.length < columns) {
return
Expand Down Expand Up @@ -178,14 +179,18 @@ function formatTests(states: TestCaseState[]): string {
continue
}

output += currentIcon.color(currentIcon.char.repeat(count))
if (count > 0) {
output += currentIcon.color(currentIcon.char.repeat(count))
}

// Start tracking new group
count = 1
currentIcon = icon
}

output += currentIcon.color(currentIcon.char.repeat(count))
if (count > 0) {
output += currentIcon.color(currentIcon.char.repeat(count))
}

return output
}
Loading