fix(reporters): prevent yellow dots in dot reporter when all tests pass#9720
Closed
pierreeurope wants to merge 1 commit intovitest-dev:mainfrom
Closed
fix(reporters): prevent yellow dots in dot reporter when all tests pass#9720pierreeurope wants to merge 1 commit intovitest-dev:mainfrom
pierreeurope wants to merge 1 commit intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
requested changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9681
The dot reporter had two bugs:
In
onTestModuleEnd, it filtered finished tests by checkingstate !== 'pending'. This incorrectly included tests in 'run' state (which haven't finished yet). The fix checks against thefinishedTestsSet instead.In
onWatcherRerun, thefinishedTestsSet wasn't cleared, causing issues with test tracking across watch reloads. Addedthis.finishedTests.clear()to fix this.In
formatTests, empty groups with count=0 were still being formatted, causing empty yellow ANSI escape sequences. Added checks to skip formatting when count is 0.The result: all dots now correctly display green when tests pass, with no spurious yellow dots remaining.