Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add error equality tests + more warnings in docs #5253

Merged
merged 5 commits into from
Feb 26, 2024
Merged

test: add error equality tests + more warnings in docs #5253

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d77a07
test: add error equality tests
hi-ogawa Feb 21, 2024
8618cf7
chore: comment
hi-ogawa Feb 21, 2024
f8bd1f1
chore: cleanup
hi-ogawa Feb 21, 2024
9b8009f
docs: more warning
hi-ogawa Feb 21, 2024
d225624
chore: comment
hi-ogawa Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: comment
  • Loading branch information
@hi-ogawa
hi-ogawa committed Feb 21, 2024
commit 8618cf7e3ad0d8926c905be0935937e01c7a515d
1 change: 0 additions & 1 deletion test/core/test/expect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,6 @@ describe('Error equality', () => {
}

const strictErrorTester: Tester = function (a: unknown, b: unknown, customTesters) {
// const a instanceof Error && b instanceof Error
const aOk = a instanceof Error
const bOk = b instanceof Error
if (aOk && bOk) {
Expand Down
Loading