Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add error equality tests + more warnings in docs #5253

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 21, 2024

Description

It doesn't look like there was a test case for error equality, so I added it.
I also added custom equality example to show how to achieve stricter behavior (like node:assert).

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit d225624
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65d59bd40709390008fcf50c

@hi-ogawa hi-ogawa marked this pull request as ready for review February 21, 2024 01:54
@hi-ogawa hi-ogawa changed the title test: add error equality tests test: add error equality tests + more warning in docs Feb 21, 2024
@hi-ogawa hi-ogawa changed the title test: add error equality tests + more warning in docs test: add error equality tests + more warnings in docs Feb 21, 2024
@sheremet-va sheremet-va merged commit 9abef3d into vitest-dev:main Feb 26, 2024
19 checks passed
@hi-ogawa hi-ogawa deleted the test-error-equality branch February 26, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants