fix: workaround for plugin type #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paescuj
force-pushed
the
fix/plugin-type
branch
from
a8d3709 to
5392a13
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small workaround to mitigate the type conflicts mentioned in #771 and #761.
The issue originates from the current incompatibility of
ESLintUtils.RuleCreatorfrom@typescript-eslintanddefineConfigfromeslint/config, see typescript-eslint/typescript-eslint#11543 for details.By forcing the
rulesvariable to beRecord<string, Rule.RuleModule>we can make it compatible for now. I think that's acceptable as the rules itself are still type checked in their own modules.The types of the configs remain detailed:
Fixes #771, fixes #761