Support the new defineConfig

[binarykitchen]

Hi

It seems your plugin doesn't support defineConfig:

import { defineConfig } from 'eslint/config';

Which is the new recommended way to build your ESLint configuration but is nowhere mentioned in your README.md

When I try it, with your plugin, there are plenty of TS errors.

Wondering if you know about it and are working on it?

Thanks

[veritem]

do you mind sharing your setup and a possible to reproduce this?

[binarykitchen]

Sure @veritem I've created a new branch eslint-define-config-vitest-problem inside my npm plugin called videomail-client.

From line 193 onwards, you see where I'm using your plugin:
https://github.com/binarykitchen/videomail-client/blob/eslint-define-config-vitest-problem/eslint.config.js#L193

Using your latest version 1.3.15.

To reproduce, just check out that branch, do a npm install and check the types with npm run types, and then this error comes up:

Argument of type '{ rules: { "vitest/prefer-expect-assertions": "off"; "vitest/max-expects": "off"; "vitest/prefer-lowercase-title": "off"; "vitest/prefer-describe-function-title": "off"; "vitest/no-hooks": [...]; ... 8 more ...; "vitest/prefer-called-exactly-once-with": "error"; }; name: "vitest/recommended"; plugins: { readonly vit...' is not assignable to parameter of type 'InfiniteArray<ConfigWithExtends>'.
  Type '{ rules: { "vitest/prefer-expect-assertions": "off"; "vitest/max-expects": "off"; "vitest/prefer-lowercase-title": "off"; "vitest/prefer-describe-function-title": "off"; "vitest/no-hooks": [...]; ... 8 more ...; "vitest/prefer-called-exactly-once-with": "error"; }; name: "vitest/recommended"; plugins: { readonly vit...' is not assignable to type 'ConfigWithExtends'.
    Types of property 'plugins' are incompatible.
      Type '{ readonly vitest: { readonly meta: { readonly name: "vitest"; readonly version: string; }; readonly rules: { readonly "prefer-lowercase-title": RuleModule<MessageIds, [Partial<{ ignore: string[]; allowedPrefixes: string[]; ignoreTopLevelDescribe: boolean; lowercaseFirstCharacterOnly: boolean; }>], PluginDocs, RuleL...' is not assignable to type 'Record<string, Plugin>'.
        Property 'vitest' is incompatible with index signature.
          Type '{ readonly meta: { readonly name: "vitest"; readonly version: string; }; readonly rules: { readonly "prefer-lowercase-title": RuleModule<MessageIds, [Partial<{ ignore: string[]; allowedPrefixes: string[]; ignoreTopLevelDescribe: boolean; lowercaseFirstCharacterOnly: boolean; }>], PluginDocs, RuleListener>; ... 73 mo...' is not assignable to type 'Plugin'.
            Types of property 'rules' are incompatible.
              Type '{ readonly "prefer-lowercase-title": RuleModule<MessageIds, [Partial<{ ignore: string[]; allowedPrefixes: string[]; ignoreTopLevelDescribe: boolean; lowercaseFirstCharacterOnly: boolean; }>], PluginDocs, RuleListener>; ... 73 more ...; readonly "prefer-called-exactly-once-with": RuleModule<...>; }' is not assignable to type 'Record<string, RuleDefinition<RuleDefinitionTypeOptions>>'.
                Property '"prefer-lowercase-title"' is incompatible with index signature.
                  Type 'RuleModule<MessageIds, [Partial<{ ignore: string[]; allowedPrefixes: string[]; ignoreTopLevelDescribe: boolean; lowercaseFirstCharacterOnly: boolean; }>], PluginDocs, RuleListener>' is not assignable to type 'RuleDefinition<RuleDefinitionTypeOptions>'.
                    Types of property 'create' are incompatible.
                      Type '(context: Readonly<RuleContext<MessageIds, [Partial<{ ignore: string[]; allowedPrefixes: string[]; ignoreTopLevelDescribe: boolean; lowercaseFirstCharacterOnly: boolean; }>]>>) => RuleListener' is not assignable to type '(context: RuleContext<{ LangOptions: LanguageOptions; Code: SourceCode<{ LangOptions: LanguageOptions; RootNode: unknown; SyntaxElementWithLoc: unknown; ConfigNode: unknown; }>; RuleOptions: unknown[]; Node: unknown; MessageIds: string; }>) => RuleVisitor'.
                        Types of parameters 'context' and 'context' are incompatible.
                          Type 'RuleContext<{ LangOptions: LanguageOptions; Code: SourceCode<{ LangOptions: LanguageOptions; RootNode: unknown; SyntaxElementWithLoc: unknown; ConfigNode: unknown; }>; RuleOptions: unknown[]; Node: unknown; MessageIds: string; }>' is missing the following properties from type 'Readonly<RuleContext<MessageIds, [Partial<{ ignore: string[]; allowedPrefixes: string[]; ignoreTopLevelDescribe: boolean; lowercaseFirstCharacterOnly: boolean; }>]>>': getAncestors, getDeclaredVariables, getScope, markVariableAsUsed

Hope this helps. Feedback welcome.

[christopher-buss]

This is probably related to typescript-eslint/typescript-eslint#11543

[binarykitchen]

Thanks Did you know about this issue before?

[haines]

There is a minimal repro here: https://github.com/haines/eslint-plugin-vitest-types (from #761).