fix: unbundle fdir to fix commonjsOptions.dynamicRequireTargets
#19791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p3-minor-bug
patak-dev
approved these changes
Apr 4, 2025
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vitebundlesfdirtransitively through@rollup/plugin-commonjs.fdiris cjs only and it usesrequire.resolve("picomatch"), but that's broken when bundled as esm.I think rollup leaving
require.resolvemight be a bug (we should havecreateRequirebanner?), but considering the story from #19487, we should avoid duplicatingfdir, so I chose it unbundle though it's a bit weird since it's transitive dep.Alternative is to unbundle
@rollup/plugin-commonjs, but I think that would also cause more duplicate bundled/unbunled transitive dep (e.g.@rollup/pluginutils), so I didn't go with that for now.