chore(deps): unbundle tinyglobby #19487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
tinyglobby
branch
2 times, most recently
from
9c554c7 to
8bba980
Compare
Member
|
If we unbundle tinyglobby, I think we should unbundle picomatch as well. picomatch is a dependency of tinyglobby and Vite uses picomatch as well. If we only unbundle tinyglobby, we'll have picomatch both bundled and unbundled. |
benmccann
force-pushed
the
tinyglobby
branch
from
8bba980 to
1625759
Compare
benmccann
force-pushed
the
tinyglobby
branch
from
1625759 to
d8f572a
Compare
Collaborator
Author
|
Great catch! I've updated it to unbundle |
sapphi-red
approved these changes
Feb 26, 2025
patak-dev
approved these changes
Mar 2, 2025
sapphi-red
changed the title
7 tasks
6 tasks
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed on Discord, there may be some benefit to very selectively unbundling some of Vite's dependencies. The time to download Vite can actually be reduced by unbundling if the dependency is also used by the framework or tools being setup alongside vite as it means we only download the copy from npm rather than both the copy from npm and bundled copy.
tinyglobby is used by vitest, solidstart, astro, vitepress, nx, vike, nuxt, unimport (used by tanstack start), vite-plugin-checker, and vite-plugin-pwa. svelte doesn't use tinyglobby yet, but may soon and we do use both of its dependencies already. Other libraries adjacent to the ecosystem like eslint-import-resolver-typescript, tsup, and unocss use it as well.