Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup golangci-lint job #859

Closed
wants to merge 5 commits into from
Closed

setup golangci-lint job #859

wants to merge 5 commits into from

Conversation

mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Mar 27, 2023

Creates a linting job with golangci-lint.
It enables the following linters:

  • gci
  • gofumpt
  • gosimple
  • govet
  • ineffassign
  • nilerr
  • revive
  • staticcheck
  • unconvert
  • whitespace

It disables the following linters:

  • errcheck
  • unused

The disabled linters shall be enabled while their errors are being addressed. This PR has enough modifications to not bring them all.

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

@mmorel-35 mmorel-35 marked this pull request as draft March 27, 2023 19:41
@mmorel-35 mmorel-35 marked this pull request as ready for review March 27, 2023 21:43
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 changed the title enable golangci-lint setup golangci-lint job Mar 28, 2023
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 closed this by deleting the head repository Feb 11, 2024
@thaJeztah thaJeztah mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant