Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gofumpt code #1009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gofumpt code #1009

wants to merge 1 commit into from

Conversation

thaJeztah
Copy link
Contributor

No description provided.

@adrianchiris
Copy link
Collaborator

great initiative,

This should ideally come with a github workflow which will ensure the project remains gofumpted.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Contributor Author

great initiative,

This should ideally come with a github workflow which will ensure the project remains gofumpted.

Yes, it would be good to set up a linter in this repo; I see #859 gave this a try, but was closed.

I just ran golangci-lint with its default options on this repo, and there's a lot of things it's flagging (not all critical), but probably better to keep separate from this PR.

At least this PR should set a baseline for formatting, and we can do some periodic updates to fix regressions in that area (until a linter is in place).

I rebased this PR, and should be ready for review again. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants