Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dissalow map prop for markers #305

Merged
merged 3 commits into from
Apr 10, 2024
Merged

feat: dissalow map prop for markers #305

merged 3 commits into from
Apr 10, 2024

Conversation

maciej-ka
Copy link
Contributor

@maciej-ka maciej-ka commented Apr 10, 2024 •
edited
Loading

Closes #284

  • check in ts examples that vs code doesn't suggest map prop
    • marker
    • advanced-marker
    • info-window (didn't had map prop)
    • map-control (didn't had map prop)

@maciej-ka maciej-ka marked this pull request as draft April 10, 2024 15:07
@maciej-ka maciej-ka marked this pull request as ready for review April 10, 2024 16:42
@usefulthink
Copy link
Collaborator

Thank you very much!

@usefulthink usefulthink merged commit 8a38acf into visgl:main Apr 10, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Merged
@maciej-ka maciej-ka deleted the 284-disallow-map-prop branch April 10, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] map prop shouldn't be valid in prop-types extending the google.maps.* types.
2 participants
@maciej-ka @usefulthink