Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] map prop shouldn't be valid in prop-types extending the google.maps.* types. #284

Closed
usefulthink opened this issue Mar 27, 2024 · 1 comment · Fixed by #305
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@usefulthink
Copy link
Collaborator

Description

Where present, the map option can be passed to google maps API objects to instantly add it to the specified map. This collides with our internal system to add/remove elements to/from the map and shouldn't be allowed.

Check all PropTypes extending google.maps.* (Marker, AdvancedMarker, InfoWindow, ...) and add Omit<T, "map"> to the declaration.

Steps to Reproduce

no

Environment

  • Library version: 0.8.x
  • Google maps version: weekly
  • Browser and Version: any
  • OS: all

Logs

No response

@usefulthink usefulthink added bug Something isn't working good first issue Good for newcomers labels Mar 27, 2024
@maciej-ka
Copy link
Contributor

maciej-ka commented Apr 10, 2024

Hi. I would like to give it a try.

Would you have short info somewhere on how to run examples folder? (I'm trying cd dist/examples and run http file server there, it ends with error Failed to resolve module specifier "@vis.gl/react-google-maps/examples.css". Relative ...)

I found example/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants