Skip to content

Respect DataT on TripsLayer props #8533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Respect DataT on TripsLayer props #8533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c26f450
Respect DataT on TripsLayer props
JayFoxRox Feb 24, 2024
43a18a9
Respect DataT on HexagonLayer props
JayFoxRox Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/aggregation-layers/src/hexagon-layer/hexagon-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ type _HexagonLayerProps<DataT = unknown> = {
/** Aggregates data into a hexagon-based heatmap. The color and height of a hexagon are determined based on the objects it contains. */
export default class HexagonLayer<DataT, ExtraPropsT extends {} = {}> extends AggregationLayer<
DataT,
ExtraPropsT & Required<_HexagonLayerProps>
ExtraPropsT & Required<_HexagonLayerProps<DataT>>
> {
static layerName = 'HexagonLayer';
static defaultProps = defaultProps;
Expand Down
2 changes: 1 addition & 1 deletion modules/geo-layers/src/trips-layer/trips-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ type _TripsLayerProps<DataT = unknown> = {
/** Render animated paths that represent vehicle trips. */
export default class TripsLayer<DataT = any, ExtraProps extends {} = {}> extends PathLayer<
DataT,
Required<_TripsLayerProps> & ExtraProps
Required<_TripsLayerProps<DataT>> & ExtraProps
> {
static layerName = 'TripsLayer';
static defaultProps = defaultProps;
Expand Down