Skip to content

Conversation

@JayFoxRox
Copy link
Contributor

@JayFoxRox JayFoxRox commented Feb 24, 2024

Closes #8507

While working on this, I briefly searched for similar errors by looking for ExtraPropsT & Required< and noticed HexagonLayer had the same issue.

Change List

  • Forward DataT from TripsLayer instance to _TripsLayerProps instance
  • Forward DataT from HexagonLayer instance to _HexagonLayerProps instance

@Pessimistress Pessimistress merged commit d3e915b into visgl:master Feb 28, 2024
Pessimistress pushed a commit that referenced this pull request Feb 28, 2024
@JayFoxRox JayFoxRox deleted the fix-trips-layer-datat branch February 29, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect usage of _TripsLayerProps (generic argument DataT not given in TripsLayer)

2 participants