TerrainExtension: Support picking on draped layers #8474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flostellbrink
changed the title
flostellbrink
force-pushed
the
feature/terrain-drape-picking
branch
2 times, most recently
from
e643a0b to
a6958b9
Compare
This demonstrates the working picking on layers draped over terrain cover.
The isPicking option is not passed down to this function. Instead we can look at the current render pass.
When rendering a picking pass, the pickingFbo is updated every time. The dirty flag refers to the rendering fbo. Previously the dirty flag was updated on picking passes too which sometimes led to the rendering fbo not being updated when it was still dirty.
flostellbrink
force-pushed
the
feature/terrain-drape-picking
branch
from
a6958b9 to
f6852be
Compare
felixpalmer
approved these changes
Feb 8, 2024
Collaborator
|
I can confirm this works well! Thanks for a great contribution 👍 Screen.Recording.2024-02-08.at.12.32.29.mov |
Pessimistress
pushed a commit
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7892
Change List
To test, start
google-3d-tilesexample locally:Just the updated example: Tooltips don't work.
Updated example and fixes: Tooltips work.