chore(core): Remove getBufferData helper #8425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
donmccurdy
force-pushed
the
donmccurdy/rm-getBufferData
branch
from
696005f to
d2bbb00
Compare
donmccurdy
force-pushed
the
donmccurdy/rm-getBufferData
branch
from
0448e60 to
5501b9f
Compare
felixpalmer
approved these changes
Jan 19, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of getBufferData we can use WebGLBuffer#readSyncWebGL2, which has the advantage of greater type safety. I'm surprised by the changes in the unit test — see comment there — but this strictly improves visual results on
test/apps/attribute-transitionso I think it's an improvement directionally.Related:
Dependencies:
Marked as draft until Luma update in #8405.