fix(core): Update AttributeTransitionUtils for Luma v9 #8392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
felixpalmer
requested changes
Jan 10, 2024
added 2 commits
January 10, 2024 09:46
felixpalmer
approved these changes
Jan 11, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8379 we updated to luma.gl v9 alpha-50, and had to disable some tests to keep the updates managable and avoid blocking other PRs. With this PR I'm revisiting attribute transitions, aiming to get those working again, or at least ready for a beta release.
This requires a deckgl-internal helper,
getBufferData, to provide synchronous reads from WebGL buffers. That isn't future proof, in a WebGPU world, but to reduce moving parts I think we need the workaround for now.With changes in this PR, attribute transition manager tests pass again. The app
test/apps/attribute-transitionsruns and displays output on screen (it previously failed). The transitions are not visually correct (see below), with the reasons for that still unknown. As this is a strict improvement over transitions throwing errors, I think it can be merged without solving the remaining issues yet.transition-progress.mov