Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92a316c2ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <script> | ||
| window.location.replace('https://www.openvisualization.org/summits/london-summit-2024' + window.location.search + window.location.hash); | ||
| </script> | ||
| <noscript><meta http-equiv="refresh" content="0; url=https://www.openvisualization.org/summits/london-summit-2024"></noscript> |
There was a problem hiding this comment.
When scripting is disabled, this fallback always redirects to the bare summit URL, unlike the JavaScript path that forwards both window.location.search and window.location.hash. Consequently, deep links such as ?ref=newsletter#agenda lose their query parameters and agenda position for exactly the users served by this fallback; use a redirect mechanism that retains the incoming URL components.
Useful? React with 👍 / 👎.
|
Coverage is 82.486% — codex/summit-redirects-9.4 into 9.4-release. No base build found for |
This branch has not been deployed
2 participants
Backports #10821 to
9.4-releaseso the release website sends visitors to the summit pages on Open Visualization.Cherry-picks both original commits with
-x: replace the five summit pages with small static redirects and remove copied CSS, image, and Madrid map assets. Redirects preserve query strings and agenda anchors and include a no-JavaScript fallback.Validation: both commits applied without conflicts; executed all five redirect scripts and verified their destinations, queries, fragments, fallback markup, and asset cleanup.
git diff origin/9.4-release --checkpasses. The original redirect implementation passedyarn test-website; the full website build was not rerun for this static-file-only backport.Deploy after the destination summit pages on Open Visualization are live. The original PR is still open; this PR targets the release branch independently.
Note
Low Risk
Static-only redirect and asset removal; no runtime or library changes, though old summit URLs depend on the external Open Visualization site being live.
Overview
Replaces full deck.gl website summit landing pages (Madrid 2022, New York 2023, London 2024, and the same pattern for Seattle 2025 and Zurich 2026) with minimal static redirect stubs that send traffic to the matching URLs on
openvisualization.org.Each stub uses JavaScript
location.replace(keeping query strings and hash fragments), a noscript meta refresh, canonical and noindex meta tags, and a short fallback link. Removes the large summit HTML, associated CSS bundles, and the Madrid deck.gl map demo (map/assets).Reviewed by Cursor Bugbot for commit 92a316c. Bugbot is set up for automated code reviews on this repo. Configure here.