Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable button on successful report #135

Merged
merged 6 commits into from
Jul 22, 2023
Merged

Disable button on successful report #135

merged 6 commits into from
Jul 22, 2023

Conversation

Robin5605
Copy link
Contributor

@Robin5605 Robin5605 commented Jul 21, 2023

Closes #131
Disable the button on a successful report, after the user has submitted the popup modal. Cancelling out of it will not disable the button. If the API returns an error response code, the button will not be disabled either.

Copy link
Member

@import-pandas-as-numpy import-pandas-as-numpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. :shipit:

Copy link
Collaborator

@sid-maddy sid-maddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, but otherwise LGTM

src/bot/exts/dragonfly/dragonfly.py Outdated Show resolved Hide resolved
Robin5605 and others added 5 commits July 22, 2023 13:12
Co-authored-by: Siddhesh Mhadnak <10049286+sid-maddy@users.noreply.github.com>
Signed-off-by: Robin <74519799+Robin5605@users.noreply.github.com>
Co-authored-by: Siddhesh Mhadnak <10049286+sid-maddy@users.noreply.github.com>
Signed-off-by: Robin <74519799+Robin5605@users.noreply.github.com>
@Robin5605 Robin5605 merged commit fa7b6ac into main Jul 22, 2023
@Robin5605 Robin5605 deleted the report-indication branch July 22, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add indication of if a package has been reported already
3 participants