Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update api/server.js #97

Merged
merged 1 commit into from
Mar 3, 2020
Merged

update api/server.js #97

merged 1 commit into from
Mar 3, 2020

Conversation

huonggiangbui
Copy link

@huonggiangbui huonggiangbui commented Mar 2, 2020 •
edited
Loading

Description

First contribution

Fixes #46

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@welcome
Copy link

welcome bot commented Mar 2, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@auto-assign auto-assign bot requested a review from vinitshahdeo March 2, 2020 19:53
@YashMeh YashMeh merged commit 83267d5 into vinitshahdeo:feature/backend-node Mar 3, 2020
@welcome
Copy link

welcome bot commented Mar 3, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

@huonggiangbui huonggiangbui deleted the huonggiangbui branch March 4, 2020 04:28
@vinitshahdeo vinitshahdeo added easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020 labels Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YashMeh YashMeh YashMeh approved these changes

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo

Assignees

@vinitshahdeo vinitshahdeo

Labels
easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huonggiangbui @YashMeh @vinitshahdeo