Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine const declarations in server.js #46

Open
6 tasks
first-timers bot opened this issue Feb 29, 2020 · 24 comments
Open
6 tasks

Combine const declarations in server.js #46

first-timers bot opened this issue Feb 29, 2020 · 24 comments
Assignees
Labels
easy Easy issue first-timers-only gssoc20 Welcome to GirlScript Summer of Code 2020 hacktoberfest

Comments

@first-timers
Copy link

first-timers bot commented Feb 29, 2020

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file api/server.js in the Water-Monitoring-System repository (press the little pen Icon) and edit the line as shown below.

@@ -1,12 +1,12 @@
-const express = require("express");
-const mongoose = require("mongoose");
-const bodyParser = require("body-parser");
-const cors = require("cors");
-const helmet = require("helmet");
-const morgan = require("morgan");
-const config = require("config");
-const app = express();
-const port = process.env.PORT || 8080;
+const express = require("express"),
+    mongoose = require("mongoose"),
+    bodyParser = require("body-parser"),
+    cors = require("cors"),
+    helmet = require("helmet"),
+    morgan = require("morgan"),
+    config = require("config"),
+    app = express(),
+    port = process.env.PORT || 8080;
 
 //Use the database uri from the ./config directory
 const dbURI = config.dbURI;
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@vinitshahdeo vinitshahdeo changed the title Update server.js Combine const declarations in server.js Feb 29, 2020
@vinitshahdeo vinitshahdeo added the gssoc20 Welcome to GirlScript Summer of Code 2020 label Feb 29, 2020
@Swarnimashukla
Copy link

I want to take this issue @vinitshahdeo .

@shibam17
Copy link

I would like to take the issue, can you assign me this?

@ashishnagpal2498
Copy link

@vinitshahdeo I would like to take this issue.

@shibam17
Copy link

I would like to take the issue, can you assign me this?

@huonggiangbui
Copy link

@jainpawan21 can I take this issue. I am very interested!

@vinitshahdeo
Copy link
Owner

@Swarnimashukla @soulhunter10737 @ashishnagpal2498 This issue is only for first-timers. Sorry, I cannot assign it to you guys.

@vinitshahdeo
Copy link
Owner

@huonggiangbui Assigning this issue to you. Expecting the PR by Tuesday, EOD.

@huonggiangbui
Copy link

@vinitshahdeo thanks! but i cannot find the file "api/server.js". Is there any problem?

@vinitshahdeo
Copy link
Owner

@huonggiangbui Please checkout feature/backend-node branch. It's not available in master.

@shreyakapoor08
Copy link

Hey, I want to work on this issue

@vinitshahdeo
Copy link
Owner

@shreyakapoor08 Hey sorry, I've already assigned this issue to @huonggiangbui.

@vinitshahdeo
Copy link
Owner

@shreyakapoor08 Will you be available to take #32 issue?

@shreyakapoor08
Copy link

@vinitshahdeo yes i will work on issue #32 . Kindly assign me that.

@huonggiangbui huonggiangbui mentioned this issue Mar 2, 2020
7 tasks
@Adyasha8105
Copy link

Hi, Please assign me this issue. I would like to work on it if he/she fails.

@huonggiangbui
Copy link

@vinitshahdeo can this issue be closed right now?

@vinitshahdeo
Copy link
Owner

Will close this once it's merged into master.

@huonggiangbui
Copy link

@vinitshahdeo My PR has merged to branch feature/backend-node. Is there any additional step I have to take? I think I completely solve this issue

@huonggiangbui
Copy link

Because file api/server.js doesnt place in branch master so I think I shouldnt merge to that branch?

@vinitshahdeo
Copy link
Owner

Nope, it's done from your end. I will merge feature/backend-node into master and this will close the issue.

@ahmedshakill
Copy link

hi i am interested in working open source .would you please assign me too

@SomyaGandhi
Copy link

Hi. I have never contributed to open source before. Can you assign this to me? @vinitshahdeo

@ayan-biswas0412
Copy link

ayan-biswas0412 commented Mar 10, 2020 via email

@kichloo
Copy link

kichloo commented Mar 17, 2020

@vinitshahdeo Pl give any task!

@EZENGESH
Copy link

I cant see the server.js file in the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Easy issue first-timers-only gssoc20 Welcome to GirlScript Summer of Code 2020 hacktoberfest
Projects
None yet
Development

No branches or pull requests