Skip to content

Commit

Permalink
Removing more ** from methods
Browse files Browse the repository at this point in the history
  - Code review for ioos#280
  • Loading branch information
vinisalazar committed Nov 30, 2022
1 parent 2349bff commit bdbc372
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions erddapy/core/interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def to_ncCF(
)
if requests_kwargs is None:
requests_kwargs = {}
return _nc_dataset(url, **requests_kwargs)
return _nc_dataset(url, requests_kwargs)


def to_xarray(
Expand All @@ -81,7 +81,7 @@ def to_xarray(
if response == "opendap":
return xr.open_dataset(url, **xarray_kwargs)
else:
nc = _nc_dataset(url, **requests_kwargs)
nc = _nc_dataset(url, requests_kwargs)
return xr.open_dataset(xr.backends.NetCDF4DataStore(nc), **xarray_kwargs)


Expand All @@ -101,7 +101,7 @@ def to_iris(
requests_kwargs = {}
if iris_kwargs is None:
iris_kwargs = {}
data = urlopen(url, **requests_kwargs)
data = urlopen(url, requests_kwargs)
with _tempnc(data) as tmp:
cubes = iris.load_raw(tmp, **iris_kwargs)
_ = [cube.data for cube in cubes]
Expand Down
4 changes: 2 additions & 2 deletions erddapy/core/netcdf.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

from contextlib import contextmanager
from pathlib import Path
from typing import Dict, Generator
from typing import Dict, Generator, Optional
from typing.io import BinaryIO
from urllib.parse import urlparse

from erddapy.core.url import urlopen


def _nc_dataset(url, **requests_kwargs: Dict):
def _nc_dataset(url, requests_kwargs: Optional[Dict] = None):
"""Return a netCDF4-python Dataset from memory and fallbacks to disk if that fails."""
from netCDF4 import Dataset

Expand Down

0 comments on commit bdbc372

Please sign in to comment.