Remove remaining ** from urlopen methods

- Code review for ioos#280
vinisalazar · Nov 30, 2022 · 2349bff · 2349bff
1 parent 85d41cf
commit 2349bff
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/erddapy/core/interfaces.py b/erddapy/core/interfaces.py
@@ -32,7 +32,7 @@ def to_pandas(
         requests_kwargs = {}
     if pandas_kwargs is None:
         pandas_kwargs = {}
-    data = urlopen(url, **requests_kwargs)
+    data = urlopen(url, requests_kwargs)
     try:
         return pd.read_csv(data, **pandas_kwargs)
     except Exception as e:

diff --git a/erddapy/core/netcdf.py b/erddapy/core/netcdf.py
@@ -13,7 +13,7 @@ def _nc_dataset(url, **requests_kwargs: Dict):
     """Return a netCDF4-python Dataset from memory and fallbacks to disk if that fails."""
     from netCDF4 import Dataset
 
-    data = urlopen(url=url, **requests_kwargs)
+    data = urlopen(url, requests_kwargs)
     try:
         return Dataset(Path(urlparse(url).path).name, memory=data.read())
     except OSError:

diff --git a/erddapy/core/url.py b/erddapy/core/url.py
@@ -28,7 +28,6 @@ def _urlopen(url: str, auth: Optional[tuple] = None, **kwargs: Dict) -> BinaryIO
 
 def urlopen(
     url: str,
-    auth: Optional[tuple] = None,
     requests_kwargs: Optional[Dict] = None,
 ) -> BinaryIO:
     """Thin wrapper around httpx get content.
@@ -39,7 +38,7 @@ def urlopen(
     # Ignoring type checks here b/c mypy does not support decorated functions.
     if requests_kwargs is None:
         requests_kwargs = {}
-    data = _urlopen(url=url, auth=auth, **requests_kwargs)  # type: ignore
+    data = _urlopen(url, **requests_kwargs)  # type: ignore
     data.seek(0)
     return data
 

diff --git a/erddapy/erddapy.py b/erddapy/erddapy.py
@@ -393,7 +393,7 @@ def _get_variables(self, dataset_id: OptionalStr = None) -> Dict:
         url = self.get_info_url(dataset_id=dataset_id, response="csv")
 
         variables = {}
-        data = urlopen(url, auth=self.auth, **self.requests_kwargs)
+        data = urlopen(url, self.requests_kwargs)
         _df = pd.read_csv(data)
         self._dataset_id = dataset_id
         for variable in set(_df["Variable Name"]):