Correctly highlight links without suffix #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a revert of ad853fe. The original changes in ad853fe claimed to be in service of this snippet: Here is some mono space linked text: [`project`](https://github.com/vim-pandoc/vim-pandoc-syntax). If I put here more `mono spaced` text, afterwards, the rest of the document is highlited wrong, try it yourself. This snippet highlights completely fine, even without the changes made in ad853fe. On the other hand, this change prevents this snippet from highlighting the `[anchor]` inside the sentence: This is an [anchor] tag that should be auto-linked. [anchor]: https://example.com I would love to revert the original change. Reverting it seems purely additive to me (does not break old behaviors, adds new behaviors).
|
LGTM too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revert of ad853fe. The original changes in ad853fe claimed
to be in service of this snippet:
This snippet highlights completely fine, even without the changes made
in ad853fe.
On the other hand, this change prevents this snippet from highlighting
the URL in the
[anchor]at the bottom:I would love to revert the original change. Reverting it seems purely
additive to me (does not break old behaviors, adds new behaviors).
Before
After
Before
After
Fixes #289