Skip to content

Allow any number of spaces before codeblock #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

jez
Copy link
Contributor

@jez jez commented Jul 11, 2022

This allows using code blocks in lists, like

- Some list item:

  ```ruby
  class A; end
  ```

- Another list item:

  ```ruby
  def foo; end
  ```

I can't quite tell the original motivation for requiring four spaces, but I have
been using this change locally for multiple weeks and it seems to work fine for
me.

Before

Screen Shot 2022-07-11 at 10 32 02 AM

After
Screen Shot 2022-07-11 at 10 31 37 AM

@jez
Copy link
Contributor Author

jez commented Jul 23, 2022

👋 @fmoralesc sorry to bother you; do you maybe have a moment to look at this PR and also #380 ?

Thanks in advance 🙏

@fmoralesc
Copy link
Member

LGTM. I can't remember why there was a need for the 4 spaces either.

@fmoralesc fmoralesc merged commit 1b77f00 into vim-pandoc:master Jul 23, 2022
@jez jez deleted the jez-code-block branch July 24, 2022 01:54
@bewuethr
Copy link

This has been bothering me forever 😅 thank you! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants