Skip to content

Optionally disable definition lists #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2017

Conversation

jez
Copy link
Contributor

@jez jez commented Feb 13, 2017

In documents which make heavy use of definition lists, vim-pandoc causes
Vim to re-render really slowly. Rather than attempt to figure out the
cause of the slowness, I've chosen to optionally disable syntax
highlighting of definition lists.

In documents which make heavy use of definition lists, vim-pandoc causes
Vim to re-render really slowly. Rather than attempt to figure out the
cause of the slowness, I've chosen to optionally disable syntax
highlighting of definition lists.
@jez
Copy link
Contributor Author

jez commented Feb 13, 2017

Diff looks cleaner when viewed without whitespace changes.

Copy link
Member

@fmoralesc fmoralesc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reword the docs. Other than that, LGTM.

@@ -77,6 +77,10 @@ CONFIGURATION *vim-pandoc-syntax-configuration*
+ *g:pandoc#syntax#style#underline_special*
Undeline subscript, superscript and strikeout text styles. Default = 1

+ *g:pandoc#syntax#style#use_definition_lists*
Detect and highlight definition lists. Looks really nice, but can result in
slower performance. Default = 1 (i.e., on by default)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not editorialize by criticizing ourselves! ;) 'Disabling this can improve performance' would be enough.

@fmoralesc fmoralesc merged commit 68d7249 into vim-pandoc:master Feb 13, 2017
@fmoralesc
Copy link
Member

All good. Thanks!

@jez jez deleted the optional-definition-lists branch February 27, 2017 20:26
davenquinn added a commit to davenquinn/vim-pandoc-syntax that referenced this pull request Aug 10, 2018
* master: (70 commits)
  Three improvements to LaTeX highlighting (vim-pandoc#216)
  Add `pandocAmpersandEscape` syntax for &...; special chars (vim-pandoc#205)
  Fix unicode with sub- or superscripts. (vim-pandoc#202)
  Optionally disable definition lists (vim-pandoc#212)
  Add support for tab-indented code blocks (vim-pandoc#207)
  Never conceal \ in \newcommand... (vim-pandoc#197)
  BufFilePRE => BufFilePre (vim-pandoc#199)
  Fixes for parenthetical citations (vim-pandoc#189)
  Fix footnotes. (vim-pandoc#188)
  Fix reference links
  Fix automatic links by restricting characters in mail links.
  Check 'termguicolors' instead of 'nvim'
  fix typo in doc
  fix for upstream issue vim-pandoc#177
  fix typo
  Conceal char for end of code block
  Add cchar for block end
  added endash and emdash support to syntaxt
  fix for neovim
  Use custom syntax group for operators
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants