Fix footnotes. #188
Merged
Fix footnotes. #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Skip over brackets inside footnotes. Otherwise things like PCites and other bracketed comments wrongly match and end the footnote early. 2. Allow for inline formatting inside footnotes. 3. Change highlighting of footnotes. (Having footnotes be Comments means they get italicized. This is not desirable since it's possible for italics to show up in footnotes.) 4. Allow for footnotes to appear in lists.
|
3 seems dependent on the colorscheme. The one I use (based on molokai), doesn't use italics for Comment, and worse, it uses color for Type. I would rather have this be a variation of Normal with less contrast (might use the functions in https://github.com/vim-pandoc/vim-pandoc-syntax/blob/master/autoload/pandoc/syntax/color.vim). |
|
Yes -- I see it's working when I change away from Solarized theme. Shall I simply revert the styling changes? |
|
Sure ;) |
|
Done. |
davenquinn
added a commit
to davenquinn/vim-pandoc-syntax
that referenced
this pull request
Aug 10, 2018
* master: (70 commits) Three improvements to LaTeX highlighting (vim-pandoc#216) Add `pandocAmpersandEscape` syntax for &...; special chars (vim-pandoc#205) Fix unicode with sub- or superscripts. (vim-pandoc#202) Optionally disable definition lists (vim-pandoc#212) Add support for tab-indented code blocks (vim-pandoc#207) Never conceal \ in \newcommand... (vim-pandoc#197) BufFilePRE => BufFilePre (vim-pandoc#199) Fixes for parenthetical citations (vim-pandoc#189) Fix footnotes. (vim-pandoc#188) Fix reference links Fix automatic links by restricting characters in mail links. Check 'termguicolors' instead of 'nvim' fix typo in doc fix for upstream issue vim-pandoc#177 fix typo Conceal char for end of code block Add cchar for block end added endash and emdash support to syntaxt fix for neovim Use custom syntax group for operators ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message below. (3) is partly a matter of taste, and I'd be happy to change
or remove that if you'd like. Other comments, of course, welcome.
and other bracketed comments wrongly match and end the footnote
early.
get italicized. This is not desirable since it's possible for italics
to show up in footnotes.)