fix unicode display #96
Merged
+62
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you @kanlac 🙏 The implementation makes sense to me, can you please add to your PR description a test case that I can try with the current version and then with your PR to see this change in action? Once I manually re-test this, the PR is good to go |
Contributor
Author
|
Sure, it's easy to reproduce. You can create a file or directory with Unicode characters, for example After this PR change, the file names will display correctly: |
Owner
|
Thank you @kanlac, I tested this locally, and it works well 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #76.
Compared to adding extra blank runes (#77), I think a more reasonable way is to fix the implementation of
GetCell.